RFR: 8002070 Remove the stack search for a resource bundle for Logger to use

Jim Gish jim.gish at oracle.com
Tue Mar 5 19:12:11 UTC 2013


On 03/03/2013 09:15 AM, Alan Bateman wrote:
> On 01/03/2013 21:25, Jim Gish wrote:
>> Please review 
>> http://cr.openjdk.java.net/~jgish/Bug8002070-RemoveResourceBundleStackSearch/ 
>> <http://cr.openjdk.java.net/%7Ejgish/Bug8002070-RemoveResourceBundleStackSearch/> 
>>
>>
>> This removes the stack search from Logger.findResourceBundle()
>>
>> Note that because this is a change in the spec/functionality, a CCC 
>> request will be filed.
> It's good to have this removed. The changes to the caching seem okay, 
> at least I don't see anything obviously wrong.
>
> One suggestion is to change "SystemClassLoader" into system 
> ClassLoader and link it to the ClassLoader.getSystemClassLoader.
done
>
> For the LoggerResourceBundleRace test then does it have to run in its 
> own VM?
Because we no longer search up the stack for the bundles, this test 
fails unless run in its own vm.  However, to avoid this, I'll try to 
change the test to set the context classloader.
>
> -Alan.

-- 
Jim Gish | Consulting Member of Technical Staff | +1.781.442.0304
Oracle Java Platform Group | Core Libraries Team
35 Network Drive
Burlington, MA 01803
jim.gish at oracle.com




More information about the core-libs-dev mailing list