RFR: 8006593: Performance and compatibility improvements to hash based Map implementations

Mike Duigou mike.duigou at oracle.com
Wed Mar 6 17:30:23 UTC 2013


On Mar 6 2013, at 09:19 , Alan Bateman wrote:

> On 05/03/2013 22:46, Mike Duigou wrote:
>> 
>> I have updated the webrev to remove the useAltHashing boolean.
>> 
>> http://cr.openjdk.java.net/~mduigou/JDK-8006593/5/webrev/
>> 
>> Mike
>> 
> Peter's suggestion to remove the useAltHashing field is a great idea.
> 
> I've looked at the webrev and it looks good to me. The logical xor in initHashSeedAsNeeded is subtle.
> 
> As this is for jdk7u only then I assume you'll get approval on jdk7u-dev once you are done here.

Yes. Per the original review request:
> Once review is completed here this patch will be proposed to JDK7u-dev for integration into the next 7u
> performance/feature release.
I am going to leave this review open for another 24 hours before requesting approval from JDK7u-dev.

Mike


More information about the core-libs-dev mailing list