Request for review- RFE 8005716
Dean Long
dean.long at oracle.com
Wed Mar 6 00:36:24 UTC 2013
If JNI_ONLOAD_SYMBOLS contains something like "_JNI_OnLoad at 8" on
Windows, you can't just
turn that into "_JNI_OnLoad at 8_" + <libname>. I think it needs to be
"_JNI_OnLoad_" + <libname> + "@8"
Looks like onLoadSymbols[] is unused in
Java_java_lang_ClassLoader_00024NativeLibrary_findBuiltinLib().
Instead of adding getProcessHandle(), why not add
JVM_FindBuiltinLibraryEntry() instead?
This would make it easier to support table-lookup when runtime symbol
information is missing or not
supported by the platform.
dl
On 3/5/2013 3:05 PM, bill.pittore at oracle.com wrote:
> This request is tied to bugid 8005716 that deals with adding support
> for statically linked JNI libraries.
>
> The JEP is here: http://openjdk.java.net/jeps/178
>
> The bug is here:http://bugs.sun.com/view_bug.do?bug_id=8005716
>
> The webrevs are here:
>
> http://cr.openjdk.java.net/~bpittore/8005716/jdk-webrev.00/
> http://cr.openjdk.java.net/~bpittore/8005716/hs-webrev.00/
>
> The main piece of functionality is to check for the presence of
> JNI_OnLoad_libname to determine if the library specified by 'libname'
> has been statically linked into the VM. If the symbol is found, it is
> assumed that the library is linked in and will not be dynamically loaded.
>
> thanks,
> bill
More information about the core-libs-dev
mailing list