RFR: 8002070 Remove the stack search for a resource bundle for Logger to use

[Jim Gish]

Mandy,

The CCC request has been approved.  Please push the changeset at 
http://cr.openjdk.java.net/~jgish/Bug8002070-RemoveResourceBundleStackSearch.patch/ 
<http://cr.openjdk.java.net/%7Ejgish/Bug8002070-RemoveResourceBundleStackSearch.patch/>


Thanks,
    Jim

On 03/08/2013 05:51 PM, Mandy Chung wrote:
> On 3/8/2013 2:39 PM, Jim Gish wrote:
>> I've update the webrev with the suggested changes: 
>> http://cr.openjdk.java.net/~jgish/Bug8002070-RemoveResourceBundleStackSearch/ 
>> <http://cr.openjdk.java.net/%7Ejgish/Bug8002070-RemoveResourceBundleStackSearch/>
>>
>
> Thumbs up.  Thanks for adding the comment in the test.  I'd suggest to 
> take out the statement about "stack walk search" since this may be 
> confusing to others who read it as that code will no longer exist.  
> Please add this bug ID to @bug.
>
> thanks
> Mandy
>
>> Thanks,
>>    Jim
>>
>>
>> On 03/08/2013 03:41 PM, Mandy Chung wrote:
>>> On 3/5/2013 11:12 AM, Jim Gish wrote:
>>>>> For the LoggerResourceBundleRace test then does it have to run in 
>>>>> its own VM?
>>>> Because we no longer search up the stack for the bundles, this test 
>>>> fails unless run in its own vm.  However, to avoid this, I'll try 
>>>> to change the test to set the context classloader. 
>>>
>>> I discussed with Jim.  In jtreg samevm mode, the testclasses are not 
>>> in the classpath and thus the system classloader can't find the 
>>> resource bundle.  Before the fix, the test finds the resource bundle 
>>> using the classloader on the stack which isn't the intent.
>>>
>>> Mandy
>>
>> -- 
>> Jim Gish | Consulting Member of Technical Staff | +1.781.442.0304
>> Oracle Java Platform Group | Core Libraries Team
>> 35 Network Drive
>> Burlington, MA 01803
>> jim.gish at oracle.com

-- 
Jim Gish | Consulting Member of Technical Staff | +1.781.442.0304
Oracle Java Platform Group | Core Libraries Team
35 Network Drive
Burlington, MA 01803
jim.gish at oracle.com