Please review: surrogate fiddle

Martin Buchholz martinrb at google.com
Mon Mar 18 22:13:01 UTC 2013


It does change the behavior.  The existing behavior is clearly a bug, since
it reads a char that should be inaccessible.  I don't believe AIOOBE
exception is thrown, with or without my fix.


On Mon, Mar 18, 2013 at 3:08 PM, Mike Duigou <mike.duigou at oracle.com> wrote:

> This change would seem to change the result when a high surrogate is the
> last char in the String/StringBuilder/StringBuffer.
>
> Rather than throwing an ArrayIndexException it will return the high
> surrogate char.
>
> I am going to defer to Sherman on this. I don't know that returning the
> character is the right thing to do.
>
> Sherman?
>
> Mike
>
> On Mar 18 2013, at 14:28 , Martin Buchholz wrote:
>
> Hello Jim, Mike,
>
> I'd like you to do a code review:
>
> http://cr.openjdk.java.net/~martin/webrevs/openjdk8/surrogate-fiddle/
>
>
>



More information about the core-libs-dev mailing list