RFR-8008118

Alan Bateman Alan.Bateman at oracle.com
Wed Mar 20 15:34:54 UTC 2013


On 20/03/2013 15:22, John Zavgren wrote:
> Greetings:
>
> Please consider the following fix for a minor memory issue that I found in the file: src/solaris/native/java/lang/UNIXProcess_md.c.
>
> http://cr.openjdk.java.net/~jzavgren/8008118/webrev.01/
>
> Thanks!
> John Zavgren
If there is a chance that we will recover then splitPath may have 
malloc'ed a few segments before failing. I don't know if you want to 
attempt to free those before bailing (could be tricky). On the other 
hand, I think this is java.lang.UNIXProcess's static initializer so the 
OOME will cause that to fail so we are probably hosed anyway.

A minor comment but it would be best to put a space in "if(" to keep it 
consistent.

-Alan



More information about the core-libs-dev mailing list