RFR-8008118
Martin Buchholz
martinrb at google.com
Wed Mar 20 23:32:36 UTC 2013
On Wed, Mar 20, 2013 at 4:23 PM, Chris Hegarty <chris.hegarty at oracle.com>wrote:
> Martin,
>
> I take your point about the other allocations, but as you say OOM is
> better than SEGV. So possibly good enough?
>
>
Ah, Thanks Chris, I had forgotten that NEW *does* throw OOME.
> If NEW returns NULL, then there will be a pending OOM on the stack.
>
>
good point!
In that case, this is indeed a clear improvement, and I leave it to John
whether to undo the allocations in splitPath before returning.
Just add that space after "if", please, before you submit!
More information about the core-libs-dev
mailing list