8010309 : PlatformLogger: isLoggable performance / waste due to HashMap<Integer, Level> leads to Integer allocations (boxing)

[Mandy Chung]

On 3/27/2013 3:19 AM, Peter Levart wrote:
> On 03/27/2013 10:32 AM, Laurent Bourgès wrote:
>> Hi Mandy, Peter,
>>
>> thanks for the review.
>>
>> I wanted the patch to be small and only in PlatformLogger class 
>> without API change to be easily backported to jdk7u.
>> Do you think this bug is JDK8 only ?
>
> I think this API level change is source-level-compatible, so only a 
> JDK rebuild is required. Will try it anyway and check whether this is 
> true. If it is then the backport is not a problem.
>

I think changing the field type is small and can be easily 
backported.    I have no issue to backport this change to jdk7u. The 
rename of the JavaLogger class and logger field has modified many lines 
of code and it's low risk but it isn't absolutely necessary.  Perhaps 
you can consider dropping the renaming to keep the fix smaller.

>
>>
>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8010309
>>
>> I submitted another patch concerning missing 
>> PlatformLogger.isLoggable(level) in the JDK (java.net 
>> <http://java.net>, java.awt mainly) but it is not widely used as I 
>> thought first.
>>
>> see http://mail.openjdk.java.net/pipermail/awt-dev/2013-March/004459.html
>>
>> Maybe in the future, other projects or JDK parts will use it if it is 
>> no more a performance bottleneck.

Yes we want other parts of JDK to use it.  There is a RFE to convert the 
remaining JDK component to use PlatformLogger:
   http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7054233

Mandy

>>
>> Cheers,
>> Laurent
>>
>