Codereview Request for 8007379: Base64.getMimeDecoder().decode() throws IAE for a non-base64 character after padding

Xueming Shen xueming.shen at oracle.com
Wed Mar 27 22:20:49 UTC 2013


Hi,

Please help review the fix for the following two bugs:

(1) 8007379: Base64.getMimeDecoder().decode() throws IAE for a non-base64 character after padding
We fixed the similar issue in 8006530, it appears there is "yet another" corner case
to close here. As described in the bug report, the calculation for output buffer size
for such case is incorrect when decoding in mime mode. The proposed change
should fix the problem.

(2) 8008925: Base64.getMimeDecoder().decode() does not ignore padding chars
The change is to clarify the specification that "the padding character(s) is not
required for decoding. BUT, if the padding character(s) does appear, they must
be correctly encoded."

http://cr.openjdk.java.net/~sherman/8007379_8008925/webrev

Thanks,
-Sherman




More information about the core-libs-dev mailing list