RFR: Optimize StringBuilder.append(null)

Laurent Bourgès bourges.laurent at gmail.com
Thu Mar 28 06:42:27 UTC 2013


Maybe the local var count could be renamed _count or c to avoid name
conflict with the member count and make the code more readable / obvious.

PS: I like final vars.

Cheers
Laurent
Le 28 mars 2013 07:31, "Martin Buchholz" <martinrb at google.com> a écrit :
>
> On Wed, Mar 27, 2013 at 4:36 PM, Remi Forax <forax at univ-mlv.fr> wrote:
>
> > On 03/27/2013 03:01 AM, Martin Buchholz wrote:
> >
> > Hi Martin,
> > the code looks good,
> > I've just noticed that you declare the char array value final in
appendNull
> > but it's not something that is usually done in the java.lang codebase.
> >
>
> It's certainly common in java.util.concurrent.  It's safer.  The
> declaration saves 50 bytes of bytecode.



More information about the core-libs-dev mailing list