Review Request: BigInteger patch for efficient multiplication and division (#4837946)

Tim Buktu tbuktu at hotmail.com
Thu May 2 01:34:48 UTC 2013


Hi Brian,

On 04/30/2013 01:40 AM, Brian Burkhalter wrote:
> To answer my own question, there are apparently about 1,000 more lines.
> It looks to me as if they are, i.e., the only changes versus the JDK8 repo are those intended for this patch.
Yes and yes :)

I just checked in a bug fix to BigInteger and a couple of improvements
to BigIntegerTest. I'm assuming you're going to go with the code at
https://github.com/tbuktu/bigint (i.e. the version that contains all
algorithms), so I didn't update the "lite version" at
https://gist.github.com/tbuktu/1576025.

Alan is working on an improved BigInteger.toString() that should be
dramatically faster for large numbers. What's the deadline for getting
this in?
Thanks,

Tim



More information about the core-libs-dev mailing list