RFR: JDK-8013736: [launcher] cleanup code for correctness

Martin Buchholz martinrb at google.com
Thu May 2 16:51:07 UTC 2013


I would also be inclined to change
== 0
to
== NULL

This seems like another occasion to use the weird

do { ... } while(0)

trick to make the macro behave more like a statement.

I might obfuscate the macro parameters to make collisions less likely, e.g.
e => N_C_RV_e




On Wed, May 1, 2013 at 12:33 PM, Kumar Srinivasan <
kumar.x.srinivasan at oracle.com> wrote:

> Hi,
>
> Please review simple fixes for code correctness in the launcher.
>
> http://cr.openjdk.java.net/~**ksrini/8013736/webrev.0/<http://cr.openjdk.java.net/~ksrini/8013736/webrev.0/>
>
> Thanks
> Kumar
>
>



More information about the core-libs-dev mailing list