RFR: 7150256: Add back Diagnostic Command JMX API

[frederic parain]

I'll fix it and file a new bug.

Fred

On 03/05/2013 20:30, Mandy Chung wrote:
> On 5/3/2013 11:19 AM, Daniel Fuchs wrote:
>> Hi,
>>
>> On 5/3/13 8:02 PM, Mandy Chung wrote:
>>> 2. Investigate what DiagnosticCommandImpl.getAttributes and
>>> setAttributes should do per DynamicMBean spec.  The current
>>> implementation throws UOE which seem to be okay.  It's good to confirm
>>> what is specified or not specified per DynamicMBean spec
>>
>> By analogy with what the MBeanServerConnection says and what
>> the StandardMBean class does, I'd say that the expected behavior
>> would be to return an empty AttributeList for both methods.
>
> Thanks Daniel.  I initially thought that these 2 methods should return
> an empty AttributeList.  MBeanServerConnection specifies clearly that
> missing attribute will be omitted and the caller will use the returned
> value to determine any missing attribute.  It makes sense to expect
> DynamicMBean.get/setAttributes the same behavior as MBS forwards the
> call to the mbeans.
>
> Frederic - you can simply fix this to return an empty AttributeList. Can
> you also file a bug for DynamicMBean to clarify the expected behavior in
> the specification?
>
> Thanks
> Mandy
>
>>
>> See:
>> <http://docs.oracle.com/javase/7/docs/api/javax/management/MBeanServer.html#getAttributes%28javax.management.ObjectName,%20java.lang.String[]%29>
>>
>>
>> and
>> <http://docs.oracle.com/javase/7/docs/api/javax/management/MBeanServer.html#setAttributes%28javax.management.ObjectName,%20javax.management.AttributeList%29>
>>
>>
>
>> -- daniel
>>
>>>
>>> Thanks
>>> Mandy
>>
>

-- 
Frederic Parain - Oracle
Grenoble Engineering Center - France
Phone: +33 4 76 18 81 17
Email: Frederic.Parain at oracle.com