RFR: 7150256: Add back Diagnostic Command JMX API

[frederic parain]

You're right. I'll update setAttributes() to return
an empty AttributeList.

Fred

On 03/05/2013 20:53, Mandy Chung wrote:
> DynamicMBean:
>      public AttributeList setAttributes(AttributeList attributes);
>
> Maybe you looked at setAttribute method.  It's easily misread with and
> without 's'.
>
> On 5/3/2013 11:40 AM, frederic parain wrote:
>> MBeanServer.setAttributes() returns an AttributeList
>> but the return type of DynamicMBean.setAttributes() is
>> void. Does it mean that in our case, setAttributes()
>> should simply be a no-op method?
>>
>> Fred
>>
>> On 03/05/2013 20:19, Daniel Fuchs wrote:
>>> Hi,
>>>
>>> On 5/3/13 8:02 PM, Mandy Chung wrote:
>>>> 2. Investigate what DiagnosticCommandImpl.getAttributes and
>>>> setAttributes should do per DynamicMBean spec.  The current
>>>> implementation throws UOE which seem to be okay.  It's good to confirm
>>>> what is specified or not specified per DynamicMBean spec
>>>
>>> By analogy with what the MBeanServerConnection says and what
>>> the StandardMBean class does, I'd say that the expected behavior
>>> would be to return an empty AttributeList for both methods.
>>>
>>> See:
>>> <http://docs.oracle.com/javase/7/docs/api/javax/management/MBeanServer.html#getAttributes%28javax.management.ObjectName,%20java.lang.String[]%29>
>>>
>>>
>>>
>>> and
>>> <http://docs.oracle.com/javase/7/docs/api/javax/management/MBeanServer.html#setAttributes%28javax.management.ObjectName,%20javax.management.AttributeList%29>
>>>
>>>
>>>
>>> -- daniel
>>>
>>>>
>>>> Thanks
>>>> Mandy
>>>
>>
>

-- 
Frederic Parain - Oracle
Grenoble Engineering Center - France
Phone: +33 4 76 18 81 17
Email: Frederic.Parain at oracle.com