RFR: JDK-8006884(2nd round): (fs) Add Files.list, lines and find
Alan Bateman
Alan.Bateman at oracle.com
Thu May 9 10:11:04 UTC 2013
On 09/05/2013 06:27, Henry Jen wrote:
> On 05/08/2013 09:17 PM, Mike Duigou wrote:
>> Looks good to me.
>>
> Thanks, we have a minor update to exclude changes for DirectoryStream.
>
> http://cr.openjdk.java.net/~henryjen/ccc/8006884.2/webrev/
>
> A quick review on the update is really appreciated.
>
Looks good to me.
Just on the FaultFileSystem used by the tests. A typo in the class
description " A FileSystem help testing". For completeness then .close
should be idempotent. Minor alignment problem in getFileStore.
Thanks for fixing the bug in the PassThroughFileSystem, that method must
not be used by the other tests that uses this test file system.
-Alan
More information about the core-libs-dev
mailing list