Request for Review 8014296: DivModTests should not compare pointers

[roger riggs]

Thanks,   I'll need help with the push (I'm not a committer for JDK).


On 5/10/2013 11:39 AM, Joe Darcy wrote:
> Good to push.
>
> -Joe
>
> On 05/10/2013 08:25 AM, roger riggs wrote:
>> Thanks, the webrev now has the correct copyright change.
>>
>>
>> On 5/10/2013 11:14 AM, Joe Darcy wrote:
>>> On 05/10/2013 08:02 AM, roger riggs wrote:
>>>> Please review this minor correction to DivModTests to address this 
>>>> issue:
>>>>     http://bugs.sun.com/view_bug.do?bug_id=8014296
>>>>
>>>> With autoboxing of mixed types primitive and Object, the operators 
>>>> == and !=
>>>> are interpreted as reference compare instead of value compares.
>>>> The compiler is silent about the likely unintended consequences.
>>>>
>>>> Webrev:
>>>> http://cr.openjdk.java.net/~rriggs/webrev-8014296-DivModTests/
>>>>
>>>> Thanks, Roger
>>>>
>>>
>>> Roger,
>>>
>>> The copyright range should now be "2012, 2013,".
>>>
>>> Otherwise, the change looks fine.
>>>
>>> -Joe
>>
>