Add getChars to CharSequence

Joe Darcy joe.darcy at oracle.com
Fri May 10 23:08:55 UTC 2013


On 05/10/2013 03:03 PM, Martin Buchholz wrote:
> On Wed, May 8, 2013 at 5:30 PM, Mike Duigou <mike.duigou at oracle.com> wrote:
>
>> - There's been some informal discussion of packaging commonly used test
>> utils as jtreg @library. This could be a good candidate. ArraysCharSequence
>> is a candidate for testing utils lib. Basic impls that override no defaults
>> are going to be increasingly important for testing.
>>
>> - I like your varargs assertsThrows. I have written a non-varargs one in
>> test/.../Map/Defaults.java. Your varargs one of necessity violates the
>> actual, expected, [message] pattern used by other TestNG assertions but I
>> prefer it. This is also a candidate for utils lib.
>>
>>
> It's good to see internal jdk support libraries emerging.  That has been an
> historic problem.
> I can relocate assertThrows and ArrayCharSequence if we can agree on a
> location.
> They both seem to belong in a jdk-wide location.
>
> assertThrows was adapted from a method of the same name in Doug's CVS,
> where it's still being used with junit.

I think it would be a fine idea is we started putting such utilities 
into a new JDK-specific package like, "jdk.testing".

-Joe



More information about the core-libs-dev mailing list