Code review request for JDK-8014365 Restore Objects.requireNonNull(T, Supplier<String>)

Joe Darcy joe.darcy at oracle.com
Tue May 14 05:17:25 UTC 2013


Thanks for the review Mike,

-Joe

On 05/13/2013 10:06 PM, Mike Duigou wrote:
> Looks fine to me. Welcome back Objects.requireNonNull(obj, Supplier)!
>
> Mike
>
> On May 10 2013, at 14:01 , Joe Darcy wrote:
>
>> Hello,
>>
>> Please (re)review this change to introduce Objects.requireNonNull(T, Supplier<String>):
>>
>>     http://cr.openjdk.java.net/~darcy/8014365.0/
>>
>> The original change had to be pulled out because of a build issue (8012343: Objects.requireNonNull(Object,Supplier) breaks genstubs build); I'll be asking for a review on build-dev of the build-related change in langtools. The test portion of the patch is slightly different than before because of the intervening changes made for
>>
>>     8013712: Add Objects.nonNull and Objects.isNull
>>
>> Thanks,
>>
>> -Joe




More information about the core-libs-dev mailing list