Code review request for JDK-8014365 Restore Objects.requireNonNull(T, Supplier<String>)

Alan Bateman Alan.Bateman at oracle.com
Wed May 15 16:47:18 UTC 2013


On 15/05/2013 17:44, Joe Darcy wrote:
> :
>
> Sorry for introduce the javadoc issue.
>
> Please review this patch
>
> --- a/src/share/classes/java/util/Objects.java    Mon May 13 22:16:55 
> 2013 -0700
> +++ b/src/share/classes/java/util/Objects.java    Wed May 15 09:43:16 
> 2013 -0700
> @@ -269,7 +269,7 @@
>       * Checks that the specified object reference is not {@code null} 
> and
>       * throws a customized {@link NullPointerException} if it is.
>       *
> -     * <p>Unlike the method {@link requireNonNull(Object, String},
> +     * <p>Unlike the method {@link #requireNonNull(Object, String)},
>       * this method allows creation of the message to be deferred until
>       * after the null check is made. While this may confer a
>       * performance advantage in the non-null case, when deciding to
>
> and I'll file a bug a push the fix.

Looks good to me.

-Alan.



More information about the core-libs-dev mailing list