Code Review Request: 7186555: (prefs) continual printing of BackingStoreException on console on Linux

Kurchi Subhra Hazra kurchi.subhra.hazra at oracle.com
Tue May 21 14:01:59 UTC 2013


On 5/21/13 1:35 AM, Mandy Chung wrote:
> Kurchi,
>
> The windows implementation also emits warning messages that should be 
> fixed up too since we don't want to emit anything to interfere the 
> application logging.  The default logging configuration (default level 
> is INFO) should apply to the application logging and the runtime like 
> this case should have a different default level (e.g SEVERE) so that 
> our implementation can use the appropriate level rather than forcing 
> to use FINE etc.  This is something for future enhancement (I'll file 
> a RFE).
>
> For this bug, have you considered setting the level to SEVERE and 
> change its default instead of changing to FINE?

Thanks for the review. That did occur to me, but I was not sure which 
one is preferable. I will do the relevant changes and get back
with another webrev.

- Kurchi

>
> Mandy
>
> On 5/21/2013 9:21 AM, Mandy Chung wrote:
>> On 5/21/2013 1:42 AM, Kurchi Hazra wrote:
>>>
>>> Hi,
>>>
>>>    Please review this change to fix 718655. The bug complaints about 
>>> continuous BackingStoreExceptions
>>> printed on the console, the user is just seeing logged warnings from 
>>> BackingStoreExceptions raised in periodic attempts to sync 
>>> preferences. Preferences use sun.util.logging.PlatformLogger.java 
>>> which is enabled by default, and has a default level of INFO. 
>>> Changing the logging in this file to FINE prevents the user from 
>>> seeing information that he/she is not interested in.
>>>    Bug: http://bugs.sun.com/view_bug.do?bug_id=7186555
>>> Webrev:http://cr.openjdk.java.net/~khazra/7186555/webrev.00/
>>>
>>
>> Looks good and L116 emits a INFO log message that should be changed 
>> to FINE too.
>>
>> Mandy
>




More information about the core-libs-dev mailing list