Code Review Request: 7186555: (prefs) continual printing of BackingStoreException on console on Linux
Kurchi Subhra Hazra
kurchi.subhra.hazra at oracle.com
Tue May 21 17:04:53 UTC 2013
On 5/21/13 9:53 AM, Kurchi Subhra Hazra wrote:
> On 5/21/13 9:40 AM, Mike Duigou wrote:
>> Any chance that it would be possible to stop the periodic attempts to
>> sync preferences?
>
> - I did think of that too - but the syncing may fail(temporarily) if
> the prefs object could not retrieve the lock to the
> associated prefs file. We could stop syncing attempts if the sync
> fails say n number of times - but I do not think
> that is a good solution.
- Just to add, why I don't think the above is a good solution, one might
be trying to acquire lock on a remote file
over NFS, and the syncing may fail temporarily because of an erratic
network connection.
> We may however be able to stop the syncing attempts if we are
> guaranteed by some error code that any future
> writing attempts will fail. I'll check on that.
>
> - Kurchi
>
>>
>> The log spamming is a symptom, not the cause.
>>
>> Could the prefs code be enhanced to better determine if writing is
>> possible before attempting and failing?
>>
>> Mike
>>
>> On May 21 2013, at 01:21 , Mandy Chung wrote:
>>
>>> On 5/21/2013 1:42 AM, Kurchi Hazra wrote:
>>>> Hi,
>>>>
>>>> Please review this change to fix 718655. The bug complaints
>>>> about continuous BackingStoreExceptions
>>>> printed on the console, the user is just seeing logged warnings
>>>> from BackingStoreExceptions raised in periodic attempts to sync
>>>> preferences. Preferences use sun.util.logging.PlatformLogger.java
>>>> which is enabled by default, and has a default level of INFO.
>>>> Changing the logging in this file to FINE prevents the user from
>>>> seeing information that he/she is not interested in.
>>>> Bug: http://bugs.sun.com/view_bug.do?bug_id=7186555
>>>> Webrev:http://cr.openjdk.java.net/~khazra/7186555/webrev.00/
>>>>
>>> Looks good and L116 emits a INFO log message that should be changed
>>> to FINE too.
>>>
>>> Mandy
>
More information about the core-libs-dev
mailing list