RFR 8014076: Arrays parallel and serial sorting improvements

Chris Hegarty chris.hegarty at oracle.com
Thu May 23 16:57:01 UTC 2013


On 05/11/2013 12:46 AM, Mike Duigou wrote:
>
> On May 10 2013, at 07:14 , Chris Hegarty wrote:
>
>> Updated webrev and specdiff.
>>
>> http://cr.openjdk.java.net/~chegar/8014076/ver.01/specdiff/java/util/Arrays.html
>
> Docs changes look fine to me.
>
>>   http://cr.openjdk.java.net/~chegar/8014076/ver.01/webrev/
>
> ArraysParallelSortHelpers::
>
> - It's strange to see serialversionid defined for classes that will never be serialized.

I think this is mainly to keep the compiler happy. We could suppress the 
warning, rather than add the serialVersionUID, but I don't think it is 
worth changing at this point. It can be revisited later if necessary.

> ParallelSorting::
>
> - Arrays.MIN_ARRAY_SORT_GRAN does this reference still work?

Thanks, it has been removed.

-Chris.

> Otherwise changes look good to me. (Depending very much on regression testing to ensure correctness of the algorithm).
>
>>
>> I incorporated the feedback so far, and reverted the change to make MIN_ARRAY_SORT_GRAN public ( there doesn't appear to be enough justification for this ).
>>
>> -Chris.
>



More information about the core-libs-dev mailing list