RFR (S) CR 8014966: Add the proper Javadoc to @Contended

Mike Duigou mike.duigou at oracle.com
Thu May 23 17:05:53 UTC 2013


This is a good improvement. I agree that David Holmes is your possible best reviewer. :-)

Mike

On May 23 2013, at 09:47 , Aleksey Shipilev wrote:

> Ummm... I think that's exactly what the last paragraph says. What if we
> rephrase it as follows?
> 
> ------------- 8< -----------------------------------------------
> When the annotation is used at the class level, the effect is
> roughly equivalent to placing the {@code @Contended} annotation
> with the anonymous tag over all the unannotated fields of the
> object. With the class level annotation, the implementations may
> choose different approach to protect the entire object, rather
> than protecting only the distinct fields.
> ------------- 8< -----------------------------------------------
> 
> -Aleksey.
> 
> On 05/23/2013 08:20 PM, Mike Duigou wrote:
>> You could add one more sentence to cover the effect of @C on class
>> with no @C on any field. The response to Peter is great info (but too
>> much detail for JavaDoc).
>> 
>> Mike
>> 
>> On May 23 2013, at 09:17 , Aleksey Shipilev wrote:
>> 
>>> On 05/23/2013 06:33 PM, Mike Duigou wrote:
>>>> A class level annotation on a class containing no annotated
>>>> fields has no effect, correct?
>>> 
>>> It does have the effect, see the last paragraph in the Javadoc.
>>> Should we refine this a bit?
>>> 
>>> -Aleksey.
>> 
> 




More information about the core-libs-dev mailing list