RFR JDK-8015299

[John Zavgren]

Greetings:

I fixed the comment line... to correct the "nul", "NULL", "NUL" issue 
and I disambiguated the readlink() issue.

Thanks!
John

On 05/26/2013 11:03 PM, David Holmes wrote:
> I concur with Martin on all counts.
>
> Confusing NUL and NULL is also a pet peeve of mine :)
>
> David
>
> On 25/05/2013 2:15 AM, Martin Buchholz wrote:
>> Hi John,
>>
>> The memory leak fix looks good.
>> ---
>> IIRC I was the author of the comment, so it is not surprising that I 
>> might
>> prefer that version.  "nul" is ___not___ a typo for NULL.  It makes no
>> sense to speak of character arrays being NULL-terminated.  It also isn't
>> quite right to say that readlink "generates" an array - it simply writes
>> into one.
>>
>> However, it is more correct to spell "nul" "NUL" as in ASCII(7).
>>
>> If you wanted to be more precise about which readlink, you could write
>> readlink(2) instead of readlink() to disambiguate from readlink(1)
>>
>>
>> On Fri, May 24, 2013 at 8:04 AM, John Zavgren 
>> <john.zavgren at oracle.com>wrote:
>>
>>> Greetings:
>>>
>>> I fixed two memory leaks in the file: jdk/src/solaris/bin/java_md_**
>>> solinux.c
>>> and I posted a webrev image of the changes at:
>>> http://cr.openjdk.java.net/~**jzavgren/8015299/webrev.01/<http://cr.openjdk.java.net/~jzavgren/8015299/webrev.01/>< 
>>>
>>> http://cr.openjdk.java.net/%**7Ejzavgren/8015299/webrev.01/<http://cr.openjdk.java.net/%7Ejzavgren/8015299/webrev.01/> 
>>>
>>>>
>>>
>>> (I also edited a comment.)
>>>
>>> Thanks!
>>> John
>>>
>>> -- 
>>> John Zavgren
>>> john.zavgren at oracle.com
>>> 603-821-0904
>>> US-Burlington-MA
>>>
>>>


-- 
John Zavgren
john.zavgren at oracle.com
603-821-0904
US-Burlington-MA