RFR 8009581: Xpathexception does not honor initcause()

Aleksej Efimov aleksej.efimov at oracle.com
Tue May 28 14:30:19 UTC 2013


Jason,
You are absolutely right and my fault that I didn't tested the 
compatibility of new/old versions.
I have tested it with JDK 8(without fix) as a serializer  and JDK 8 
(with fix) as deserializer. The behavior was as you expected. Thanks for 
catching it.
I'll wait for other comments before generating another webrev.

Aleksej

On 05/28/2013 05:41 PM, Jason Mehrens wrote:
> > Alan, David,
> > thank you for comments - I also agree with all of them. And as a 
> result v3:
> > http://cr.openjdk.java.net/~dmeetry/8009581/webrev.3/
> > >> I think this looks better. I assume that since the 
> super.getCause() is
> > >> null that there is no need to handle IllegalStateException now.
>
> You can still generate a ISE inside readObject by performing "new 
> XPathException(new Exception()).initCause(null)" in the old code and 
> then reading that in the new patch.  In the new code that line would 
> fail fast.
>
> Jason




More information about the core-libs-dev mailing list