PING! - RFR 7032154: Performance tuning of sun.misc.FloatingDecimal/FormattedFloatingDecimal

[Martin Buchholz]

Looks good to me.


On Thu, May 30, 2013 at 2:18 PM, Brian Burkhalter <
brian.burkhalter at oracle.com> wrote:

> Hi Martin,
>
> The changes you suggested below have been made and the webrev updated at
>
> http://cr.openjdk.java.net/~bpb/7032154/
>
> All pertinent JTREG and JCK tests have been re-run successfully.
>
> Thanks!
>
> Brian
>
> On May 29, 2013, at 4:57 PM, Martin Buchholz wrote:
>
> The code is awesome.  My thorough review found only these defects:
>
> Use third person in the first sentence of a javadoc - e.g.
> s/Retrieve/Retrieves/.
>
> ---
>
> Don't use the denigrated C style
> char zero[] =
> Instead use
> char[] zero =
>
> ---
> This looks odd:
>
> normalized as a//binary*
>
>
> The original comment looked more normal:
>
> normalized as a *binary*
>
> ---
>
> Otherwise, approved!
>
>
>