JDK-8027351: (ref) Base's class finalize method not invoked if a private finalize method exists in its subclass

Alan Bateman Alan.Bateman at oracle.com
Tue Nov 5 10:38:29 UTC 2013


On 05/11/2013 02:21, Mandy Chung wrote:
>
> Fixed.  Revised webrev at:
> http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8027351/webrev.03/
>
I looked at the latest webrev.

Having runFinalization and runAllFinalizers be a no-open during 
initialization is reasonable (it should never happen).

I agree with Peter's suggestion to move the 
SharedSecrets.getJavaLangAccess() into the run methods.

As regards the booted flag then there are a few places where VM.isBooted 
is used so it be better to leave it as volatile (it's only used in a few 
places to having it synchronized is unlikely to make an observable 
difference).

-Alan.



More information about the core-libs-dev mailing list