RFR: 8028185 - XMLFormatter.format emits incorrect year

[Daniel Fuchs]

On 11/19/13 6:40 PM, Mandy Chung wrote:
> On 11/19/13 2:23 AM, Daniel Fuchs wrote:
>> Hi,
>>
>> Please find below a webrev for:
>>
>> 8028185: XMLFormatter.format emits incorrect year
>> https://bugs.openjdk.java.net/browse/JDK-8028185
>>
>> The fix is trivial:
>> http://cr.openjdk.java.net/~dfuchs/webrev_8028185/webrev.00/
>

Thanks for the review Mandy!

> Looks good.   Nit: the test can use StringBuilder which is generally in
> preference to StringBuffer unless synchronization is required.

Oh yes good catch - I will change it before pushing...

>
> The kind of warning fix [1] causing this regression should probably have
> a regression test to go with it to verify the change.
>
> thanks
> Mandy
> [1] http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c1f129f62f36