RFR: JDK-8028628 - java/nio/channels/FileChannel/Size.java failed once in the same binary run
Mandy Chung
mandy.chung at oracle.com
Wed Nov 20 03:08:29 UTC 2013
On 11/19/2013 3:57 PM, Dan Xu wrote:
> Hi All,
>
> Please review the simple fix towards Size.java testcase. It failed
> once on windows platform in the recent same binary run, which is
> mostly due to some interferences and the special delete handling on
> windows.
>
> In the fix, I remove the delete operation in initTestFile() method
> because FileOutputStream will truncate the file content and it is not
> necessary to delete it first. Thanks!
>
> Bug:https://bugs.openjdk.java.net/browse/JDK-8028628
> Webrev: http://cr.openjdk.java.net/~dxu/8028628/webrev/
> <http://cr.openjdk.java.net/%7Edxu/8028628/webrev/>
The patch itself is okay. Would you think if writing to a file in the
current directory rather than temp is less prone to the interference?
Mandy
More information about the core-libs-dev
mailing list