RFR 8028516 Java doc error in Int/Long/Double/Stream.peek

[Chris Hegarty]

Look good to me Paul.

-Chris

On 22/11/13 11:24, Paul Sandoz wrote:
> Hi,
>
> https://bugs.openjdk.java.net/browse/JDK-8028516
>
> An attendee of the Devoxx lambda hackathon spotted some doc bugs in code samples of the stream peek methods.
>
> I updated those samples to be stand alone samples and verified they compile.
>
> Paul.
>
> diff -r 4bc37b6c4133 src/share/classes/java/util/stream/DoubleStream.java
> --- a/src/share/classes/java/util/stream/DoubleStream.java	Thu Nov 21 16:02:16 2013 -0800
> +++ b/src/share/classes/java/util/stream/DoubleStream.java	Fri Nov 22 12:23:30 2013 +0100
> @@ -207,12 +207,12 @@
>        * @apiNote This method exists mainly to support debugging, where you want
>        * to see the elements as they flow past a certain point in a pipeline:
>        * <pre>{@code
> -     *     list.stream()
> -     *         .filter(filteringFunction)
> -     *         .peek(e -> System.out.println("Filtered value: " + e));
> -     *         .map(mappingFunction)
> -     *         .peek(e -> System.out.println("Mapped value: " + e));
> -     *         .collect(Collectors.toDoubleSummaryStastistics());
> +     *     DoubleStream.of(1, 2, 3, 4)
> +     *         .filter(e -> e > 2)
> +     *         .peek(e -> System.out.println("Filtered value: " + e))
> +     *         .map(e -> e * e)
> +     *         .peek(e -> System.out.println("Mapped value: " + e))
> +     *         .sum();
>        * }</pre>
>        *
>        * @param action a <a href="package-summary.html#NonInterference">
> diff -r 4bc37b6c4133 src/share/classes/java/util/stream/IntStream.java
> --- a/src/share/classes/java/util/stream/IntStream.java	Thu Nov 21 16:02:16 2013 -0800
> +++ b/src/share/classes/java/util/stream/IntStream.java	Fri Nov 22 12:23:30 2013 +0100
> @@ -200,12 +200,12 @@
>        * @apiNote This method exists mainly to support debugging, where you want
>        * to see the elements as they flow past a certain point in a pipeline:
>        * <pre>{@code
> -     *     list.stream()
> -     *         .filter(filteringFunction)
> -     *         .peek(e -> System.out.println("Filtered value: " + e));
> -     *         .map(mappingFunction)
> -     *         .peek(e -> System.out.println("Mapped value: " + e));
> -     *         .collect(Collectors.toIntSummaryStastistics());
> +     *     IntStream.of(1, 2, 3, 4)
> +     *         .filter(e -> e > 2)
> +     *         .peek(e -> System.out.println("Filtered value: " + e))
> +     *         .map(e -> e * e)
> +     *         .peek(e -> System.out.println("Mapped value: " + e))
> +     *         .sum();
>        * }</pre>
>        *
>        * @param action a <a href="package-summary.html#NonInterference">
> diff -r 4bc37b6c4133 src/share/classes/java/util/stream/LongStream.java
> --- a/src/share/classes/java/util/stream/LongStream.java	Thu Nov 21 16:02:16 2013 -0800
> +++ b/src/share/classes/java/util/stream/LongStream.java	Fri Nov 22 12:23:30 2013 +0100
> @@ -205,12 +205,12 @@
>        * @apiNote This method exists mainly to support debugging, where you want
>        * to see the elements as they flow past a certain point in a pipeline:
>        * <pre>{@code
> -     *     list.stream()
> -     *         .filter(filteringFunction)
> -     *         .peek(e -> System.out.println("Filtered value: " + e));
> -     *         .map(mappingFunction)
> -     *         .peek(e -> System.out.println("Mapped value: " + e));
> -     *         .collect(Collectors.toLongSummaryStastistics());
> +     *     LongStream.of(1, 2, 3, 4)
> +     *         .filter(e -> e > 2)
> +     *         .peek(e -> System.out.println("Filtered value: " + e))
> +     *         .map(e -> e * e)
> +     *         .peek(e -> System.out.println("Mapped value: " + e))
> +     *         .sum();
>        * }</pre>
>        *
>        * @param action a <a href="package-summary.html#NonInterference">
> diff -r 4bc37b6c4133 src/share/classes/java/util/stream/Stream.java
> --- a/src/share/classes/java/util/stream/Stream.java	Thu Nov 21 16:02:16 2013 -0800
> +++ b/src/share/classes/java/util/stream/Stream.java	Fri Nov 22 12:23:30 2013 +0100
> @@ -403,12 +403,12 @@
>        * @apiNote This method exists mainly to support debugging, where you want
>        * to see the elements as they flow past a certain point in a pipeline:
>        * <pre>{@code
> -     *     list.stream()
> -     *         .filter(filteringFunction)
> -     *         .peek(e -> System.out.println("Filtered value: " + e));
> -     *         .map(mappingFunction)
> -     *         .peek(e -> System.out.println("Mapped value: " + e));
> -     *         .collect(Collectors.intoList());
> +     *     Stream.of("one", "two", "three", "four")
> +     *         .filter(e -> e.length() > 3)
> +     *         .peek(e -> System.out.println("Filtered value: " + e))
> +     *         .map(String::toUpperCase)
> +     *         .peek(e -> System.out.println("Mapped value: " + e))
> +     *         .collect(Collectors.toList());
>        * }</pre>
>        *
>        * @param action a <a href="package-summary.html#NonInterference">
>