RFR: JDK-8023278: Reflection API methods do not throw AnnotationFormatError in case of malformed Runtime[In]VisibleTypeAnnotations attribute
Joel Borggr?n-Franck
joel.franck at oracle.com
Fri Nov 22 14:35:24 UTC 2013
Thanks for the review Joe
cheers
/Joel
On 2013-11-21, Joe Darcy wrote:
> Hi Joel,
>
> Looks fine; thanks,
>
> -Joe
>
> On 11/21/2013 11:50 AM, Joel Borggrén-Franck wrote:
> >Hi
> >
> >Please review this fix to the type annotation reflection parser. The wrong kind of exception was thrown in the case of malformed Runtime[In]VisibleTypeAnnotations .
> >
> >Also the parser needed to be fixed for sign issues in a handful of places.
> >
> >The test has tree broken classes encoded that tests a few of the error paths in the parser, I have also run the reproducer from JCK attached to the bug report and it passes.
> >
> >bug: https://bugs.openjdk.java.net/browse/JDK-8023278
> >webrev: http://cr.openjdk.java.net/~jfranck/8023278/webrev.00/
> >
> >cheers
> >/Joel
> >
>
More information about the core-libs-dev
mailing list