RFR (JAXP) 8028822 : Error in the documentation for newFactory method of the javax.xml.stream factories

huizhe wang huizhe.wang at oracle.com
Tue Nov 26 22:13:05 UTC 2013


On 11/26/2013 1:37 PM, Alan Bateman wrote:
> On 26/11/2013 18:38, huizhe wang wrote:
>> Hi all,
>>
>> Here's revised webrev, as Alan suggested, including the implementation.
>>
>> http://cr.openjdk.java.net/~joehw/jdk8/jaxp16MR/8028822/webrev/
> So is this handling the null case correctly? It is spec'ed to use the 
> TCCL but it looks like it's going through to ServiceLoader.load where 
> null means the system class loader. Maybe this needs to wait for tests 
> as that it really the only way to check this.

Ah, I missed that. I took it for granted that since 
ServiceLoader.load(service) uses TCCL, load(service, null) would use 
TCCL. I've updated the webrev now:

http://cr.openjdk.java.net/~joehw/jdk8/jaxp16MR/8028822/webrev/

I've re-submitted a JPRT build, will send that to JCK.

-Joe

>
> -Alan




More information about the core-libs-dev mailing list