Review request for JDK-8021398: j.l.r.Parameter.getAnnotatedType().getType() for not annotated use of type returns null

Joel Borggren-Franck joel.franck at oracle.com
Tue Oct 1 08:06:04 UTC 2013


Hi Eric,

Thanks for fixing this.

On 2013-10-01, Eric McCorkle wrote:
> Hello, please review this simple patch which fixes a problem in the type
> annotations handling API.  This manifests as a problem with both
> j.l.r.Parameter.getAnnotatedType().getType() as well as
> j.l.r.Executable.getAnnotatedParameterTypes().getType().
> 
> The webrev is here:
> http://cr.openjdk.java.net/~emc/8021398/
> 
> The bug report is here:
> https://bugs.openjdk.java.net/browse/JDK-8021398
> 

Fix looks mostly fine, but please use the shared array on line 47
instead of allocating a new one.

Also you lack a test, adopt the test from the bug and add it to
jdk/test/java/lang/annotations/typeAnnotations/

cheers
/Joel



More information about the core-libs-dev mailing list