RFR: 8025067: (xs) Arrays.parallelPrefix may fail to throw NPE for null op
Paul Sandoz
paul.sandoz at oracle.com
Tue Oct 1 08:23:23 UTC 2013
On Oct 1, 2013, at 12:39 AM, Mike Duigou <mike.duigou at oracle.com> wrote:
> After posting the webrev I decided that an update to the regression test was going to be necessary. Here's the updated webrev including additional unit tests. Unfortunately I had to cut-and-paste some "library" code for exception checking. The "library" code will need to be cleaned up eventually.
>
> http://cr.openjdk.java.net/~mduigou/JDK-8025067/1/webrev/
>
+1
FWIW i am not sure i like things by default catching Throwable since it could obfuscate infrastructure errors and test errors. IMHO it would be better to re-use Runnable for runtime exceptions and another iface for checked exceptions of type T.
Re: "library code, yes, we need a more concerted effort for tests to re-use a common test utility library.
Paul.
More information about the core-libs-dev
mailing list