SplittableRandom update

Joe Darcy joe.darcy at oracle.com
Tue Oct 1 16:03:17 UTC 2013


On 10/1/2013 4:18 AM, Paul Sandoz wrote:
> On Sep 20, 2013, at 5:30 PM, Martin Buchholz <martinrb at google.com> wrote:
>> Looks good.
>>
>> Random nitpicks:
>>
>> I prefer the old variable name DOUBLE_UNIT to DOUBLE_ULP; else you are
>> inventing a slightly different meaning for ULP.
>>
>> I think using hex floating point literals is preferred:
>>
>> -    private static final double DOUBLE_ULP = 1.0 / (1L << 53);
>> +    private static final double DOUBLE_ULP = 0x1.0p-53;
>>
> I don't have any strong preference on the above comments, Doug?

Please use the hex literals in a case like this; it is exactly the 
situation they were designed for.

-Joe



More information about the core-libs-dev mailing list