Review java.time test refactoring

roger riggs roger.riggs at oracle.com
Tue Oct 1 18:53:47 UTC 2013


Ping, needs a Reviewer.

   http://cr.openjdk.java.net/~rriggs/webrev-serial-refactor-8024896/

Updated the webrev with the renamed test classes to distinguish them 
from the
non-serialization tests in a different package.

Thanks, Roger

On 9/23/2013 11:04 AM, Stephen Colebourne wrote:
> The change looks fine AFAICT. I would prefer to see the new serial
> package test classes have names that end in "Serialization", eg
> "TCKLocalDateSerialization", but if that does not happen it is not the
> end of the world.
> Stephen
>
>
> On 18 September 2013 22:31, roger riggs<roger.riggs at oracle.com>  wrote:
>> A review of the TCK tests for java.time resulted in a number of changes
>> including refactoring the serialization tests into subpackages to follow JCK
>> conventions,
>> discovery that a number of tests were missing for serialization, and cleanup
>> of the test code to utilize common test functions for testing serialization.
>> Thanks to the JCK folks for identifying the issues and doing some of the
>> refactoring.
>>
>> Webrev:
>>    http://cr.openjdk.java.net/~rriggs/webrev-serial-refactor-8024896/
>>
>>   * JDK-8024896<https://bugs.openjdk.java.net/browse/JDK-8024896>
>>     Refactor java.time serialization tests into separate subpackage
>>
>>   * JDK-8024427<https://bugs.openjdk.java.net/browse/JDK-8024427>
>>     Missing java.time.chrono serialization tests
>>
>> Thanks, Roger
>>




More information about the core-libs-dev mailing list