Please Review fix for reduced value parser 8024076

roger riggs roger.riggs at oracle.com
Wed Oct 2 17:20:18 UTC 2013


Hi Sherman,

The BASE_DATE is the default ChronoLocalDate and is used outside of RPP.
RPP itself uses any ChronoLocalDate, not the specific one.
Scoping BASE_DATE to RPP would not delay the initialization
since it would need to be initialized at line 1715.

Roger



On 10/2/2013 12:54 PM, Xueming Shen wrote:
> Should move the static field BASE_DATE into ReducePrinterParser?
> Logically (and for performance, if it matters at all) RPP appears to
> be a better place for this constant.
>
> The rest looks fine.
>
> -Sherman
>
> On 10/02/2013 08:19 AM, roger riggs wrote:
>> Please review this fix for parsing two digit years in an Chronology.
>>
>> The webrev includes Stephen's proposed alternate method that provides
>> a ChronoLocalDate as the base date.
>>
>> http://cr.openjdk.java.net/~rriggs/webrev-two-digit-8024076/
>>
>> Thanks, Roger
>>
>> p.s. the design issue raised in the comments has been filed as [2] : 
>> 8025828
>>
>> [1]https://bugs.openjdk.java.net/browse/JDK-8024076
>> [2]https://bugs.openjdk.java.net/browse/JDK-8025828
>>
>>
>




More information about the core-libs-dev mailing list