RFR: 8013839: Enhance Logger API for handling of resource bundles

Mandy Chung mandy.chung at oracle.com
Thu Oct 3 15:32:26 UTC 2013


Hi Daniel,

On 10/3/2013 7:47 AM, Daniel Fuchs wrote:
>
> The new webrev is here:
> http://cr.openjdk.java.net/~dfuchs/webrev_8013839/webrev.07/

Looks good.  Thanks for improving the javadoc.

line 1264  formatting nits - there are extra spaces that can be removed.

1892      * @throws NullPointerException if the given bundle is {@code null}.

This is already captured in the package summary.  No need to specify this
@throws NPE.

setResourceBundle(bundle) forgets to check NPE (it should call 
Objects.requireNonNull(bundle).  I think it should move line 1913-1915 
to the beginning after NPE check.   I think canReplaceResourceBundle 
method body is simple that inlining in line 1908 would be cleaner and 
still readable.

Mandy



More information about the core-libs-dev mailing list