JDK 8 RFR 7179567: JCK8 tests: api/java_net/URLClassLoader/index.html#Ctor3 failed with NPE

Michael McMahon michael.x.mcmahon at oracle.com
Fri Oct 4 10:49:37 UTC 2013


On 04/10/13 01:35, Alan Bateman wrote:
> On 03/10/2013 16:10, Brian Burkhalter wrote:
>> Please review and comment at your convenience.
>>
>> Issue:    https://bugs.openjdk.java.net/browse/JDK-7179567
>> Webrev:    http://cr.openjdk.java.net/~bpb/7179567/
>>
>> Summary
>> * Document and throw IAE from URLClassLoader constructors.
> If urls is null then it looks like the long standing behavior is to 
> throw NPE. If so then would be simpler to just specify that rather 
> than switching to IAE?
>

I agree. Documenting NPE seems reasonable to me. I'm not convinced of 
the need
for any behavior changes in the class.

Michael.

> :
>
>> * Clarify specification of SecureClassLoader.getPermissions.
>>
> A minor comment on SecureClassLoader is that you might want to align 
> the @throws to match the other @exception usages in the class.
>
> Will you be adding tests for these cases to the webrev?
>
> -Alan.




More information about the core-libs-dev mailing list