JDK 8 code review request for JDK-8025913 - Rename jdk.Supported to jdk.Exported
Jonathan Gibbons
jonathan.gibbons at oracle.com
Fri Oct 4 16:53:38 UTC 2013
On 10/03/2013 11:43 PM, Joe Darcy wrote:
> Hello,
>
> Per previous discussions on the mailing list, we've decided to rename
> the annotation type "jdk.Supported" to "jdk.Exported".
>
> Other than the file rename, the changes to the contents of the type
> are below:
>
> /**
> - * Indicates whether or not a JDK specific type or package is a
> - * supported part of the JDK.
> + * Indicates whether or not a JDK specific type or package is an
> + * exported part of the JDK suitable for use outside of the JDK
> + * implementation itself.
> *
> * This annotation should only be applied to types and packages
> * <em>outside</em> of the Java SE namespaces of {@code java.*} and
> * {@code javax.*} packages. For example, certain portions of {@code
> * com.sun.*} are official parts of the JDK meant to be generally
>
> @@ -42,12 +43,12 @@
> * @since 1.8
> */
> @Documented
> @Retention(RetentionPolicy.RUNTIME)
> @Target({ElementType.TYPE, ElementType.PACKAGE})
> - at Supported
> -public @interface Supported {
> + at Exported
> +public @interface Exported {
> /**
> - * Whether or not this package or type is a supported part of the
> JDK.
> + * Whether or not the annotated type or package is an exported
> part of the JDK.
> */
> boolean value() default true;
> }
>
> The webrev
>
> http://cr.openjdk.java.net/~darcy/8025913.0/
>
> also contains the update for replacing all previous uses of
> jdk.Supported in the langtools repo with jdk.Exported. The Supported
> annotation type was not applied outside of langtools.
>
> Rebuild of langtools with this change and a clean build of the jdk
> both worked fine.
>
> Thanks,
>
> -Joe
Looks OK to me.
-- Jon
More information about the core-libs-dev
mailing list