[7u-dev] Request for review of backport 7147084

[Ivan Gerasimov]

Alan, Rob, Martin,

Would you please help review the backport? I see you were the reviewers 
for the master fix.
I need a review for the backport, since the patch couldn't get applied 
cleanly.

Here are the changes I had to make:
- I had to manually replace Java_java_lang_ProcessImpl_create()
function body with the new version, as 'hg patch' could not handle it
automatically.
- I had to replace wide-char strings to regular char*, in all the
calls to win32Error() function.

Thanks in advance,
Ivan


On 25.09.2013 17:50, Ivan Gerasimov wrote:
> Hello!
>
> May I please have a review for a backport of the fix for 7147084 to 
> jdk7u-dev?
>
> This webrev does not include fix 8007454 anymore, as it has already 
> been pushed.
> http://cr.openjdk.java.net/~igerasim/7147084/1/webrev/
>
> Thanks in advance,
> Ivan Gerasimov
>
>
> -------- Original Message --------
> Subject:     Re: [7u-dev] Request for approval for CRs 8007454, 7147084
> Date:     Tue, 24 Sep 2013 10:29:04 +0100
> From:     Seán Coffey <sean.coffey at oracle.com>
> To:     Ivan Gerasimov <ivan.gerasimov at oracle.com>
> CC:     jdk7u-dev at openjdk.java.net
>
>
>
> On 24/09/2013 10:25, Ivan Gerasimov wrote:
>> Thanks Seán!
>>
>> Then I'll ask for an approval to backport 8007454, which is applied
>> cleanly.
> Consider both bugs fixes approved. You could use this mail thread to
> review the 7147084 changes if you want. They're innocent enough. Alan or
> someone else should be able to review.
>
> regards,
> Sean.
>> And once it is pushed, I'll initiate a review for 7147084 with
>> adjustments.
>>
>> Sincerely,
>> Ivan
>>
>> On 24.09.2013 12:59, Seán Coffey wrote:
>>> Approved for jdk7u-dev but you'll need a review first due to the
>>> adjustments needed in the backport.
>>>
>>> Hopefully, you'll be resolving these issues with 2 different
>>> changesets. It's been the trend in the past and helps keep changesets
>>> more aligned to those in JDK 8.
>>>
>>> regards,
>>> Sean.
>>>
>>> On 24/09/2013 09:08, Ivan Gerasimov wrote:
>>>> Sending to the correct ML
>>>>
>>>> --------------
>>>>
>>>> Hello!
>>>>
>>>> We have a request to backport fix for 7147084.
>>>>
>>>> First, it depends on the fix for 8007454, so the webrev includes it
>>>> too.
>>>> Second, the fix had to be adjusted a bit.
>>>> - I had to manually replaced Java_java_lang_ProcessImpl_create()
>>>> function body with the new version, as 'hg patch' could not handle
>>>> automatically.
>>>> - I had to replace wide-char strings to regular char*, in all the
>>>> calls to win32Error() function.
>>>>
>>>> Combined webrev:
>>>> http://cr.openjdk.java.net/~igerasim/7147084/0/webrev/
>>>>
>>>> BUGS:
>>>> http://bugs.sun.com/view_bug.do?bug_id=7147084
>>>> http://bugs.sun.com/view_bug.do?bug_id=8007454
>>>>
>>>> JDK8 Changesets:
>>>> 7147084: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2c4f1081a0fa
>>>> 8007454: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0a2b308cc82d
>>>>
>>>> Reviews for jdk8 fix:
>>>>
>>>> 7147084:
>>>> http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-August/019604.html 
>>>>
>>>> 8007454:
>>>> http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-February/014602.html 
>>>>
>>>>
>>>> I had set up a JPRT job, which completed successfully.
>>>> All the .*jdk_lang.* test passed.
>>>>
>>>> Sincerely yours,
>>>> Ivan Gerasimov
>>>
>>>
>>>
>>
>
>
>
>
>
>
>