JDK 8 RFC 7189139 version 2: BigInteger's staticRandom field can be a source of bottlenecks

Brian Burkhalter brian.burkhalter at oracle.com
Tue Oct 8 20:05:09 UTC 2013


On Oct 4, 2013, at 1:33 AM, Paul Sandoz wrote:

> On Oct 4, 2013, at 9:18 AM, Aleksey Shipilev <aleksey.shipilev at oracle.com> wrote:
> 
>> On 10/04/2013 03:34 AM, Brian Burkhalter wrote:
>>> Here is an alternative solution:http://cr.openjdk.java.net/~bpb/7189139.2/.
>> 
>> Seems OK with me,
> 
> Same here.

Based on previous comments by Aleksey and Paul I created this test

http://cr.openjdk.java.net/~bpb/7189139/PrimeTest.java

and ran it with the list of primes supplied by Aleksey, N=60000000, and certainty=100. This is the output:

---
Primes: /Users/bpb/Desktop/primes-50M.txt
N = 60000000
certainty = 100
3562115 probable primes out of 3562115 candidates
Prime test = true
Not-prime test = true
Test succeeded!
---

An updated webrev which differs only in having a correct Hg header is here:

http://cr.openjdk.java.net/~bpb/7189139/webrev.2/

If this looks good to go, would a Reviewer please issue an approval?

Thanks,

Brian


More information about the core-libs-dev mailing list