Review request for 8026027: Level.parse should return the custom Level instance instead of the mirrored Level

[Daniel Fuchs]

On 10/9/13 2:39 AM, Mandy Chung wrote:
> This fixes Level.parse to return the custom Level instance.
>
> Webrev at:
> http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8026027/webrev.00/
>
> When a custom Level is created, a mirrored level instance (containing 
> the same value as the custom Level) is created and used by the logging 
> implementation.  Only the custom level should be added to the known 
> level list from which Level.parse will look up.
>
> Thanks
> Mandy

Hi Mandy,

This looks good - but I think you could move the changes line 554-562 and
put them back inside the KnownLevel constructor where they were before.
This would allow you to keep mirroredLevel final.

Small nit: the name 'custom' is a misnomer - as it will be true for both 
standard and
custom levels...

Concerning the test I don't think you need to copy the property file to 
test.classes,
because I believe jprt puts test.src inside the classpath.
(another possibility would be to use a custom subclass of 
ListResourceBundle instead)

Finally,  I think that test needs to be run in main/othervm mode - 
otherwise it might
fail intermittently...

best regards,

-- daniel