JDK 8 code review request forJDK-8024354: Explicitly permit DoubleStream.sum()/average() implementations to use higher precision summation
Joseph Darcy
joe.darcy at oracle.com
Thu Oct 10 01:30:52 UTC 2013
I'll pushed with the terminal op reordering you've suggested; thanks for
the reviews,
-Joe
On 10/9/2013 6:17 PM, Mike Duigou wrote:
> For consistency I would move the "this is a terminal operation" paragraph to just before the @apiNote. I would suggest after the @apiNote but there's no mechanism for ending a javadoc tag other than starting another tag and we don't want the terminal text in the apiNote.
>
> Other than that it looks correct.
>
> Mike
>
> On Oct 9 2013, at 17:57 , Joe Darcy wrote:
>
>> On 10/09/2013 04:47 PM, Mike Duigou wrote:
>>> Big improvement. This looks like the right direction. DoubleStream.average() needs the same treatment for completeness.
>> Thanks Mike. Next iteration incorporating this feedback (and some other off-list feedback):
>>
>> http://cr.openjdk.java.net/~darcy/8024354.2
>>
>> -Joe
>>
>>
More information about the core-libs-dev
mailing list