[7u-dev] Request for review of backport 7147084

[Ivan Gerasimov]

Thank you Alan!

On 09.10.2013 14:06, Alan Bateman wrote:
> On 09/10/2013 08:47, Ivan Gerasimov wrote:
>> Alan, Rob, Martin,
>>
>> Would you please help review the backport? I see that you were the 
>> reviewers for the master fix.
>> I need a review for the backport, since the patch couldn't get 
>> applied cleanly.
>>
>> Here are the changes I had to make:
>> - I had to manually replace Java_java_lang_ProcessImpl_create()
>> function body with the new version, as 'hg patch' could not handle it
>> automatically.
>> - I had to replace wide-char strings to regular char*, in all the
>> calls to win32Error() function.
>>
>> Thanks in advance,
>> Ivan
>>
> I looked over the webrev and it seems to match the jdk8 changes except 
> for the win32Error usage. So I think it's okay. One thing to mention 
> is that there is a patch under review to fix issues with the test so 
> this should probably be pushed to jdk7u-dev too.
>
Yes, thanks. I'll keep an eye on it.

Sincerely yous,
Ivan