RFR: Lambda 8026213: Reflection support for private methods in interfaces
Karen Kinnear
karen.kinnear at oracle.com
Thu Oct 10 13:49:19 UTC 2013
David,
Thanks for the information.
The VM side of this is 8011311 which pushed on 10/8 to jdk8 master to be part of JDK8b111.
thanks,
Karen
On Oct 10, 2013, at 5:06 AM, David Holmes wrote:
> Hi Karen,
>
> On 10/10/2013 8:13 AM, Karen Kinnear wrote:
>>
>> Please review:
>>
>> webrev: http://cr.openjdk.java.net/~acorn/8026213/webrev/
>> bug: https://bugs.openjdk.java.net/browse/JDK-8026213
>>
>> Summary:
>> Reflection generates code dynamically to speed up reflection processing after startup. The first
>> 15 runs of a reflection call use the vm code path, after that we use the generated code path, which
>> needs to use invokespecial on private methods in interfaces.
>
> Minor nit:
>
> 30 import java.lang.reflect.*;
>
> The approved style these days is to list the exact imports needed rather than rely on import-on-demand.
>
> Otherwise change seems fine. Is the VM side of this already in place or does this need to sync with a VM change?
>
> Thanks,
> David
>
>
>> Tested:
>> Test attached to the bug
>>
>> Also - all the 8011311 private method testing was run with this in the build:
>> Robert Field's TypeTest
>> 8025475 test
>> defmeth privatemethodstest with reflection
>> John Rose's intfbug
>> jtreg: java.util, java.lang
>> jck vm, lang
>>
>> thanks,
>> Karen
>>
>>
More information about the core-libs-dev
mailing list