JDK 8 RFR 7179567: JCK8 tests: api/java_net/URLClassLoader/index.html#Ctor3 failed with NPE

Brian Burkhalter brian.burkhalter at oracle.com
Thu Oct 10 18:05:53 UTC 2013


On Oct 9, 2013, at 8:32 PM, David Holmes wrote:

> In the text:
> 
> * @exception  NullPointerException if {@code urls} or any of its elements
> *             is {@code null}
> 
> I'm unsure if it should be "is null" or "are null" given the initial subject is singular and latter subject is plural. Existing similar phrases seem to be split roughly 50-50.

I have changed these to
     * @exception  NullPointerException if {@code urls} or at least one of its
     *             elements is {@code null}.
Update: http://cr.openjdk.java.net/~bpb/7179567/webrev.5/
> Nit: In the test there are a few places where you have t on a line by itself:
> 
> 65                                t);
> 
> but it can go on the previous line and not exceed the length of other lines nearby. Also "+ should be " +

I don't see what you are referring to.

Thanks,

Brian


More information about the core-libs-dev mailing list