RFR: 8008733: Psr:perf:osb performance regression (18%) in wss_bodyenc
Aleksey Shipilev
aleksey.shipilev at oracle.com
Fri Oct 11 14:30:27 UTC 2013
On 10/11/2013 06:06 PM, Aleksej Efimov wrote:
> I don't think we need a regression test for it, but we need to make sure
> the regression is gone. In attempt to prove it, I have done two simple
> hprof run [2] on a test app [3] that creates 100000 instances of
> XPathContext in a cycle.
While I agree with the fix, profiling is the no-go way to confirm the
performance regression and the fix, especially with the broken test you
have in [3]. You need to build targeted benchmarks, see e.g. jmh:
http://openjdk.java.net/projects/code-tools/jmh/
> [1] http://cr.openjdk.java.net/~aefimov/8008733/webrev.00/
Looks good. What a mess is that code anyway!
> [3]
> http://cr.openjdk.java.net/~aefimov/8008733/XPathContextPerformance.java
-Aleksey.
More information about the core-libs-dev
mailing list