JDK 8 RFR 7179567: JCK8 tests: api/java_net/URLClassLoader/index.html#Ctor3 failed with NPE
Michael McMahon
michael.x.mcmahon at oracle.com
Fri Oct 11 15:31:36 UTC 2013
Looks fine to me.
Michael
On 11/10/13 16:15, Brian Burkhalter wrote:
> Thanks.
>
> Any further comments from anyone else?
>
> Brian
>
> On Oct 10, 2013, at 9:04 PM, David Holmes wrote:
>
>> Ship it! :)
>>
>> Thanks,
>> David
>>
>> On 11/10/2013 5:24 AM, Brian Burkhalter wrote:
>>> On Oct 10, 2013, at 11:21 AM, Brian Burkhalter wrote:
>>>
>>>> On Oct 10, 2013, at 11:05 AM, Brian Burkhalter wrote:
>>>>
>>>>>> Nit: In the test there are a few places where you have t on a line by itself:
>>>>>>
>>>>>> 65 t);
>>>>>>
>>>>>> but it can go on the previous line and not exceed the length of other lines nearby. Also "+ should be " +
>>>>> I don't see what you are referring to.
>>>> Oh, sorry, now I do. Will update.
>>> I hope that as of now all nits have been picked.
>>>
>>> http://cr.openjdk.java.net/~bpb/7179567/webrev.5/
>>>
>>> Thanks,
>>>
>>> Brian
>>>
More information about the core-libs-dev
mailing list