RFR [8023431] Test java/util/zip/GZIP/GZIPInZip.java failed

Ivan Gerasimov ivan.gerasimov at oracle.com
Mon Oct 14 16:34:28 UTC 2013


Thank you Sherman!

Ivan

On 14.10.2013 20:40, Xueming Shen wrote:
> looks fine.
>
> On 10/14/2013 02:51 AM, Ivan Gerasimov wrote:
>> Hello all!
>>
>> Would you please help review a fix for the intermittently failing 
>> regtest?
>> http://bugs.sun.com/view_bug.do?bug_id=8023431
>>
>>
>> The reasons of the failures were non closed PipedInput/OutputStreams.
>> Thus Read/write dead end were reported.
>>
>> The fix is to use try-with-resource for appropriate closing the streams.
>> Here is the webrev:
>> http://cr.openjdk.java.net/~igerasim/8023431/0/webrev/
>>
>> In addition to the fix I added a small enhancement to the test itself.
>> Now it also tests that the ZipStream isn't closed in the case of 
>> malformed nested GZiped entries.
>>
>> Sincerely yours,
>> Ivan Gerasimov
>>
>
>
>




More information about the core-libs-dev mailing list